PATCH: remove_sta in wpa_sta_disconnect()

Jouni Malinen jkmaline
Sun Aug 22 22:18:20 PDT 2004

On Wed, Aug 18, 2004 at 08:49:20AM +0200, Gunter Burchardt wrote:

> In wpa_sta_disconnect() hapd->driver.remove_sta() is called and after
> it STA_REMOVE is set to inform that the station should be removed. The
> first one is not ok! STA_REMOVE causes to remove the sta from all
> places in hostapd and kernel (hapd->driver.remove_sta() is also
> called). If the station is removed from kernel before accounting stop
> is sent there are no accounting information available from kernel for
> the sta.

Thanks, applied.

> Secondly in the patch is a sanity check whether a terminate cause is
> set for the sta.

Hmm.. I do not fully understand why this patch would be needed. There is
no requirement to include Acct-Terminate-Cause in Accounting-Request and
NAS Error sounds somewhat odd default reason for cases that had no cause
configured. Not sending Acct-Terminate-Cause sounds better to me in this
case. Am I missing something here?

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list