modversion issue on redhat 9

[Jouni Malinen]

On Tue, Aug 26, 2003 at 11:03:11PM -0700, Jun Sun wrote:

> Basically if you compile hostap modules for a redhat 9 box, you
> will end up many unresolved kernel symbols when you install the modules.
> 
> The problem is that hostap would include linux/modversions.h file ahead
> of all other header files, but in reality this file needs to be included
> after linux/rhconfig.h file because many #ifdef's used there.

I use only the vanilla kernel tarballs from www.kernel.org. If vendors
make incompatible changes to these, I will not notice it and someone
else will have to make a workaround for it. I can then consider
including the patch if it is clean, necessary, and does not break any
existing functionality.

> I attached a quick hack here which makes thing work.  I suspect
> the true fix is in linux/modversions.h, which should include
> linux/rhconfig.h

I think that the real solution is to use kernel Makefiles when building
the Host AP modules. Just run plain 'make' in Host AP top directory. I
have not tested it with Red Hat kernels, though. If it does not work,
we can consider what else could be done to resolve the issue.

> diff -Nru hostap/Makefile.orig hostap/Makefile
> --- hostap/Makefile.orig	2003-08-26 14:32:03.000000000 -0700
> +++ hostap/Makefile	2003-08-26 17:49:55.000000000 -0700
> @@ -86,7 +87,7 @@
>  endif
>  
>  ifdef CONFIG_MODVERSIONS
> -CFLAGS += -DMODVERSIONS -include $(KERNEL_PATH)/include/linux/modversions.h
> +CFLAGS += -DMODVERSIONS -include $(KERNEL_PATH)/include/linux/rhconfig.h -include $(KERNEL_PATH)/include/linux/modversions.h
>  endif

Doesn't this break compilation for all non-RH kernels? In general, my
policy is not to add distro-specific changes to the Host AP tarball. The
best place for these would be in a separate patch file that could be
used, e.g., in an RPM.

-- 
Jouni Malinen                                            PGP id EFC895FA