rtmpdump updates for Ubuntu and derivatives

[Jon Davies]

Following the various discussions around rtmpdump, I've today added a
patch to rtmpdump and uploaded it to
ppa:jon-hedgerows/get-iplayer-testing

The patched version should be available in the next few hours once
launchpad has built it.  It seems to work for me, but I haven't been
having the problems others have reported.

The patch is shown below:  note that the only change I made was to
change the buffer size from 64*1024 to 64*4096 - changing the other
1024s in the same function would (from my analysis) have broken the
size/progress reporting.  I've tested this briefly, and this patched
version correctly reports size downloaded and % complete.

Note that this is a statically linked version of rtmpdump - it does
not update the shared librtmp library, since doing so breaks several
other packages on Ubuntu.

Please let me know whether this works for you or not...

Regards
Jon

-------------------------------------------------------------------------

diff --git a/rtmpdump.c b/rtmpdump.c
index 13741a7..bc606a1 100644
--- a/rtmpdump.c
+++ b/rtmpdump.c
@@ -444,7 +444,7 @@ Download(RTMP * rtmp,		// connected RTMP object
 	 FILE * file, uint32_t dSeek, uint32_t dStopOffset, double duration,
int bResume, char *metaHeader, uint32_t nMetaHeaderSize, char
*initialFrame, int initialFrameType, uint32_t nInitialFrameSize, int
nSkipKeyFrames, int bStdoutMode, int bLiveStream, int bRealtimeStream,
int bHashes, int bOverrideBufferTime, uint32_t bufferTime, double
*percent)	// percentage downloaded [out]
 {
   int32_t now, lastUpdate;
-  int bufferSize = 64 * 1024;
+  int bufferSize = 64 * 4096;
   char *buffer;
   int nRead = 0;
   off_t size = ftello(file);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 002-rtmpdump.c-buffersize.patch
Type: application/octet-stream
Size: 707 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/get_iplayer/attachments/20130118/9f2028cb/attachment.obj>