[PATCH] Output AAC as M4A for iTunes with metadata tags (Shevek)

dinkypumpkin dinkypumpkin at gmail.com
Thu Mar 31 15:56:59 EDT 2011


On 31 Mar 2011, at 20:52, Shevek wrote:

> On 31 March 2011 20:49, dinkypumpkin <dinkypumpkin at gmail.com> wrote:
>> 
>> 
>> Path to ffmpeg exe might have spaces, so should be quoted as well.
>> 
> 
> good spot...
> 
> it's odd, because up till now none of the paths have been quoted, but
> it has always worked, even with paths with spaces in - is this because
> of the system() call which I am now changing?

Yes.  Perl pros here should correct me, but I think now that you effectively passing a list of length = 1 to system() or open3 (under the hood of main::run_cmd), you need to handle all internal quoting yourself.




More information about the get_iplayer mailing list