AW: [PATCH 1/1] zedboard: add support for usb

[Michael Graichen]

Hey Lucas, 

[...]
> This change does 3 distinct things and should be split in 3 patches to
> do one thing at a time:
> - add Zynq EHCI support
> - add ULPI PHY ID
> - add Zedboard USB pinmux

no problem, I can split this is separate patches.

[...]
> Maybe update the defconfig too, if it doesn't blow up the image size
> too much?

This is the harder part. It actually needs support of CONFIG_USB_ULPI and CONFIG_USB_EHCI 

+config USB_EHCI_ZYNQ
+	bool "Support for Xilinx Zynq on-chip EHCI USB controller"
+	depends on ARCH_ZYNQ
+	select USB_EHCI
+	select USB_ULPI
+	help
+	  Enable support for Zynq on-chip EHCI USB controller
+

and that will blow up the image size, because ethernet is selected in zynq_defconfig right now.  
If you want to do somethink usefull, like CONFIG_USB_STORAGE, with it its even worse.

That's why I came up with the two stage boot process from the other patch. 

[...]
> pdata isn't used anywhere AFAICS, maybe drop it and simplify the code?

right, I'll remove that. 

best regards 
Michael