[PATCH 6/9] net: add LiteEth driver

[Antony Pavlov]

On Thu, 6 May 2021 12:10:38 +0200
Roland Hieber <rhi at pengutronix.de> wrote:

Hi !

> On Wed, May 05, 2021 at 01:08:57PM +0300, Antony Pavlov wrote:
> > LiteEth provides a small footprint and configurable Ethernet core.
> > 
> > LiteEth is part of LiteX libraries whose aims are to lower entry level of
> > complex FPGA cores by providing simple, elegant and efficient implementations
> > of components used in today's SoC such as Ethernet, SATA, PCIe, SDRAM Controller...
> > 
> > Using Migen to describe the HDL allows the core to be highly and easily configurable.
> > 
> > LiteEth can be used as LiteX library or can be integrated with your standard
> > design flow by generating the verilog rtl that you will use as a standard core.
> > 
> > See https://github.com/enjoy-digital/liteeth for details.
> > 
> > Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
> > Signed-off-by: Marek Czerski <m.czerski at ap-tech.pl>
> > ---
> >  drivers/net/Kconfig   |   8 +
> >  drivers/net/Makefile  |   1 +
> >  drivers/net/liteeth.c | 376 ++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 385 insertions(+)
> > 
> > Cc: Marek Czerski <m.czerski at ap-tech.pl>
> > 
...
> > diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> > index 656d45a868..bb751943f6 100644
> > --- a/drivers/net/Makefile
> > +++ b/drivers/net/Makefile
> > @@ -36,3 +36,4 @@ obj-$(CONFIG_DRIVER_NET_TAP)		+= tap.o
> >  obj-$(CONFIG_DRIVER_NET_TSE)		+= altera_tse.o
> >  obj-$(CONFIG_DRIVER_NET_EFI_SNP)	+= efi-snp.o
> >  obj-$(CONFIG_DRIVER_NET_AG71XX)		+= ag71xx.o
> > +obj-$(CONFIG_DRIVER_NET_LITEETH)	+= liteeth.o
> > diff --git a/drivers/net/liteeth.c b/drivers/net/liteeth.c
> > new file mode 100644
> > index 0000000000..137cb854c5
> > --- /dev/null
> > +++ b/drivers/net/liteeth.c
> > @@ -0,0 +1,376 @@
> > +/*
> 
> Could you please add an SPDX-License-Identifier header [1] here? (Maybe
> also for other newly introduced files in this series, haven't checked.)
> 
> [1]: https://www.kernel.org/doc/html/latest/process/license-rules.html
> 

Original driver by Joel Stanley contains MODULE_LICENSE("GPL").
This is a bit confusing because I can't determine exact GPL version.

To: Joel Stanley

Can I add `SPDX-License-Identifier: GPL-2.0-or-later` or
`SPDX-License-Identifier: GPL-2.0-only` to the LiteEth barebox driver header?


> > + * LiteX Liteeth Ethernet
> > + *
> > + * Copyright 2017 Joel Stanley <joel at jms.id.au>
> > + *
> > + * Ported to barebox from linux kernel
> > + *   Copyright (C) 2019-2021 Antony Pavlov <antonynpavlov at gmail.com>
> > + *   Copyright (C) 2021 Marek Czerski <m.czerski at ap-tech.pl>
> > + *
> > + */

-- 
Best regards,
  Antony Pavlov