[PATCH 14/18] overlay: Add filters to choose which overlays to apply

Sascha Hauer s.hauer at pengutronix.de
Mon Jun 28 13:13:08 PDT 2021


Hi Michael,

On Mon, Jun 28, 2021 at 08:58:45PM +0200, Michael Riesch wrote:
> Hello Sascha,
> 
> On 6/24/21 10:52 AM, Sascha Hauer wrote:
> > [...]
> > +
> > +static int of_overlay_global_fixup(struct device_node *root, void *data)
> > +{
> > +	char *dir;
> > +	int ret;
> > +
> > +	if (*of_overlay_dir == '/')
> > +		return of_overlay_apply_dir(root, of_overlay_dir, true);
> > +
> > +	dir = concat_path_file(of_overlay_basedir, of_overlay_dir);
> > +
> > +	ret = of_overlay_apply_dir(root, of_overlay_dir, true);
> 
> shouldn't this be
> 
> 	ret = of_overlay_apply_dir(root, dir, true);
> 
> in order to use the concatenated path?

Yes. I fixed it up like that.

Regards,
  Sascha



-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list