[PATCH 1/3] include: <linux/barebox-wrapper.h>: remove kthread 'replacements'

Ahmad Fatoum a.fatoum at pengutronix.de
Mon Feb 15 05:27:38 EST 2021


Replacing kthread_create, stop and wake_up_process with no-ops is not
always applicable. For example a threaded USB gadget could be ported
by blocking in kthread_run as external events come in via poller.

Allow porting kthread code that way by removing the noop
implementations. The only user is the UBIFS code, so move the
definitions there.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
 drivers/mtd/ubi/ubi-barebox.h   | 2 --
 fs/ubifs/misc.h                 | 3 +++
 include/linux/barebox-wrapper.h | 4 ----
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/mtd/ubi/ubi-barebox.h b/drivers/mtd/ubi/ubi-barebox.h
index 7ee87ffd3e10..01b84890f01e 100644
--- a/drivers/mtd/ubi/ubi-barebox.h
+++ b/drivers/mtd/ubi/ubi-barebox.h
@@ -42,8 +42,6 @@ static inline unsigned long copy_from_user(void *dest, const void *src,
 
 /* common */
 
-#define wake_up_process(...)	do { } while (0)
-
 #define BUS_ID_SIZE		20
 
 #define MAX_ERRNO		4095
diff --git a/fs/ubifs/misc.h b/fs/ubifs/misc.h
index 82f922565757..5dafe7518be0 100644
--- a/fs/ubifs/misc.h
+++ b/fs/ubifs/misc.h
@@ -27,6 +27,9 @@
 #ifndef __UBIFS_MISC_H__
 #define __UBIFS_MISC_H__
 
+#define kthread_stop(...)	do { } while (0)
+#define wake_up_process(...)	do { } while (0)
+
 /**
  * ubifs_zn_dirty - check if znode is dirty.
  * @znode: znode to check
diff --git a/include/linux/barebox-wrapper.h b/include/linux/barebox-wrapper.h
index 82c52dd93309..dfaec7b8a9b9 100644
--- a/include/linux/barebox-wrapper.h
+++ b/include/linux/barebox-wrapper.h
@@ -38,10 +38,6 @@ static inline void vfree(const void *addr)
 #define __init
 #define __exit
 
-#define kthread_create(...)	__builtin_return_address(0)
-#define kthread_stop(...)	do { } while (0)
-#define wake_up_process(...)	do { } while (0)
-
 typedef int irqreturn_t;
 #define IRQ_NONE 0
 #define IRQ_HANDLED 0
-- 
2.29.2




More information about the barebox mailing list