[PATCH 3/3] usb: gadget: dfu: Replace printf with pr_err

[Ahmad Fatoum]

Hello Jules,

On 08.02.21 17:34, Jules Maselbas wrote:
> Signed-off-by: Jules Maselbas <jmaselbas at kalray.eu>
> ---
>  drivers/usb/gadget/dfu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/dfu.c b/drivers/usb/gadget/dfu.c
> index 95e8da82e..a28e7c9e8 100644
> --- a/drivers/usb/gadget/dfu.c
> +++ b/drivers/usb/gadget/dfu.c
> @@ -351,7 +351,7 @@ static void dfu_do_copy(struct dfu_work *dw)
>  
>  	ret = copy_file(DFU_TEMPFILE, dfu_file_entry->filename, 0);
>  	if (ret) {
> -		printf("copy file failed\n");
> +		pr_err("dfu: copy file failed\n");

Like with Linux, you could define pr_fmt(fmt) "dfu: " fmt before including
any headers and that prefix will be applied for all pr_ in that file.

>  		dfu->dfu_state = DFU_STATE_dfuERROR;
>  		dfu->dfu_status = DFU_STATUS_errWRITE;
>  		return;
> @@ -396,7 +396,7 @@ dfu_bind(struct usb_configuration *c, struct usb_function *f)
>  
>  	dfu->dnreq = usb_ep_alloc_request(c->cdev->gadget->ep0);
>  	if (!dfu->dnreq) {
> -		printf("usb_ep_alloc_request failed\n");
> +		pr_err("dfu: usb_ep_alloc_request failed\n");
>  		status = -ENOMEM;
>  		goto out;
>  	}
> @@ -445,7 +445,7 @@ dfu_bind(struct usb_configuration *c, struct usb_function *f)
>  
>  	i = 0;
>  	file_list_for_each_entry(dfu_files, fentry) {
> -		printf("dfu: register alt%d(%s) with device %s\n",
> +		pr_err("dfu: register alt%d(%s) with device %s\n",
>  				i, fentry->name, fentry->filename);
>  		i++;
>  	}
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |