[PATCH] startup: Fix do_autoboot_countdown() running multiple times

Sascha Hauer s.hauer at pengutronix.de
Wed Jul 1 01:26:42 EDT 2020


On Mon, Jun 29, 2020 at 10:37:43AM +0200, Ahmad Fatoum wrote:
> Hi,
> 
> On 6/26/20 8:41 AM, Sascha Hauer wrote:
> > The comment above do_autoboot_countdown() states: "This function can be
> > called multiple times, it is executed only the first time.". Since
> > 1973892533 ("startup: don't clobber original autoboot state") This is no
> > longer the case. Bring back the old and documented behaviour.
> 
> guilty as charged. I didn't read the comment..
> do_autoboot_countdown is called only once though in the code base.
> How do you make use of being able to call it multiple times?

We use this in a customer project. The decision whether we want to abort
boot or not has to be made earlier. That said, it's out of tree code, so
should this hurt anywhere else, we can change it and find another
solution for our customer.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list