[PATCH 07/10] ratp: implement ping as a standard ratp command

Sascha Hauer s.hauer at pengutronix.de
Tue Feb 6 01:33:38 PST 2018


On Fri, Feb 02, 2018 at 12:14:39PM +0100, Aleksander Morgado wrote:
> Signed-off-by: Aleksander Morgado <aleksander at aleksander.es>
> ---
>  commands/Makefile    |  1 +
>  commands/ratp-ping.c | 38 ++++++++++++++++++++++++++++++++++++++
>  common/ratp.c        | 27 ---------------------------

Can we put the ratp commands to a separate directory like
common/ratp/commands/ or similar?
There doesn't seem to be very much code sharing between the regular
commands and their ratp correspondents. Most good commands are written
in the way that the functionality is in common code outside the command
file itself anyway.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list