[PATCH 3/4] usbgadget: only set to peripheral mode when error checking is done

[Oleksij Rempel]

On Wed, Sep 27, 2017 at 11:12:44AM +0200, Sascha Hauer wrote:
> Only begin to modify the hardware when the obious errors have been
> checked.
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
>  drivers/usb/gadget/autostart.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/autostart.c b/drivers/usb/gadget/autostart.c
> index a27be899c3..2ca979057e 100644
> --- a/drivers/usb/gadget/autostart.c
> +++ b/drivers/usb/gadget/autostart.c
> @@ -39,8 +39,6 @@ static int usbgadget_autostart(void)
>  	if (!autostart)
>  		return 0;
>  
> -	setenv("otg.mode", "peripheral");
> -
>  	opts = xzalloc(sizeof(*opts));
>  	opts->release = usb_multi_opts_release;
>  
> @@ -60,6 +58,8 @@ static int usbgadget_autostart(void)
>  		return 0;
>  	}
>  
> +	setenv("otg.mode", "peripheral");
> +
>  	ret = usb_multi_register(opts);
>  	if (ret)
>  		usb_multi_opts_release(opts);
> -- 
> 2.11.0
> 
> 

Reviewed-by: Oleksij Rempel <o.rempel at pengutronix.de>

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |