[PATCH 11/6] net/e1000: expand timeout for flash erasure

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Nov 23 03:12:37 PST 2017

Erasing the whole flash takes approximately 7s on one of my test
machines. Expand the timeout accordingly.

Note however that it is in general not allowed to hold the flash
semaphore for so long and "firmware might implement a timeout
mechanism and take ownership of the relevant [lock]" after one second.
So a chip erase should better only be done when firmware doesn't make
use of the flash.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
 drivers/net/e1000/eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/e1000/eeprom.c b/drivers/net/e1000/eeprom.c
index 0d91a88bd74f..0f1305c8499b 100644
--- a/drivers/net/e1000/eeprom.c
+++ b/drivers/net/e1000/eeprom.c
@@ -854,7 +854,7 @@ static int e1000_flash_mode_erase_chunk(struct e1000_hw *hw, loff_t offset,
 	ret = e1000_poll_reg(hw, E1000_FLSWCTL,
-			     SECOND);
+			     10 * SECOND);
 	if (ret < 0) {
 			"Timeout waiting for FLSWCTL.DONE to be set (erase)\n");

More information about the barebox mailing list