> +
> + if (gpio_is_valid(nopphy->reset)) {
> + /*
> + * Let's wait for 100 ms before deasserting reset line
> + */
> + mdelay(100);
> + gpio_direction_output(nopphy->reset, 0);
> + }
Why not gpio_set_value() here? Direction is already configured at this
stage.
Nikita