[PATCH] lseek: ensure errno is set on failure and return -1

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Feb 23 13:28:41 PST 2017


All error paths before calling the driver's lseek callback return -1 and
set errno. Do the same if the callback returns an error.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
---
 fs/fs.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/fs/fs.c b/fs/fs.c
index 2b4659cfbb76..e7b696591433 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -926,7 +926,13 @@ loff_t lseek(int fildes, loff_t offset, int whence)
 		goto out;
 	}
 
-	return fsdrv->lseek(&f->fsdev->dev, f, pos);
+	pos = fsdrv->lseek(&f->fsdev->dev, f, pos);
+	if (pos < 0) {
+		errno = -pos;
+		return -1;
+	}
+
+	return pos;
 
 out:
 	if (ret)
-- 
2.11.0




More information about the barebox mailing list