[PATCH 4/9] PCI: imx6: Rename imx6_pcie_start_link() to imx6_pcie_establish_link()

Bjorn Helgaas bhelgaas at google.com
Wed May 4 14:53:21 PDT 2016


On Tue, Apr 26, 2016 at 12:37 AM, Andrey Smirnov
<andrew.smirnov at gmail.com> wrote:
> Rename imx6_pcie_start_link() to imx6_pcie_establish_link() to follow the
> convention of other DesignWare-based host drivers.  No functional change.
>
> [Andrey Smirnov: port to BB codebase]
> Signed-off-by: Andrey Smirnov <andrew.smirnov at gmail.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas at google.com>
> Acked-by: Pratyush Anand <pratyush.anand at gmail.com>

This is apparently intended for barebox (?), not for the Linux kernel,
so I'm going to ignore it.  I assume you're not looking for any action
from me.  If you are, note that I only act on things posted to
linux-pci at vger.kernel.org.

It would help me sort this out and maybe help future code
archaeologists if your changelog referenced the Linux commit more
explicitly, e.g.,

  port Linux kernel commit fd5da2081b07 ("PCI: imx6: Rename
imx6_pcie_start_link() to imx6_pcie_establish_link()") to barebox

It wouldn't hurt my feelings if you didn't copy me on patches like
this.  I don't really have anything to contribute to barebox, so it's
just something to look at and figure out whether I'm supposed to do
something with it.

Bjorn

> ---
>  drivers/pci/pci-imx6.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pci-imx6.c b/drivers/pci/pci-imx6.c
> index 13a8b22..30bc4fe 100644
> --- a/drivers/pci/pci-imx6.c
> +++ b/drivers/pci/pci-imx6.c
> @@ -415,7 +415,7 @@ static int imx6_pcie_wait_for_speed_change(struct pcie_port *pp)
>  }
>
>
> -static int imx6_pcie_start_link(struct pcie_port *pp)
> +static int imx6_pcie_establish_link(struct pcie_port *pp)
>  {
>         struct imx6_pcie *imx6_pcie = to_imx6_pcie(pp);
>         uint32_t tmp;
> @@ -483,7 +483,7 @@ static void imx6_pcie_host_init(struct pcie_port *pp)
>
>         dw_pcie_setup_rc(pp);
>
> -       imx6_pcie_start_link(pp);
> +       imx6_pcie_establish_link(pp);
>  }
>
>  static void imx6_pcie_reset_phy(struct pcie_port *pp)
> --
> 2.5.5
>



More information about the barebox mailing list