[PATCH] ARM: i.MX53-qsb: Fix gpio button polarity

Sascha Hauer s.hauer at pengutronix.de
Mon Feb 29 23:22:23 PST 2016


Since 253fb33 (input: gpio-keys: convert to input framework) the
gpio-buttons are registered with the input framework which has the
side effect that they are activated during boot and no longer have
to be activated manually by activating the input device console.
This reveals that the gpio-button polarities are wrong: The autoboot
is no longer running through since a gpio button press is wrongly
detected.
Fix the polarities in the barebox dts for now to get back a working
board. A proper fix has been sent upstream to the kernel. Once this
has landed and propagated back to barebox this patch can be reverted.

Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
 arch/arm/dts/imx53-qsb-common.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/dts/imx53-qsb-common.dtsi b/arch/arm/dts/imx53-qsb-common.dtsi
index bf634e4..85e1b8b 100644
--- a/arch/arm/dts/imx53-qsb-common.dtsi
+++ b/arch/arm/dts/imx53-qsb-common.dtsi
@@ -19,6 +19,24 @@
 			device-path = &bareboxenv;
 		};
 	};
+
+	/*
+	 * The buttons are marked as active high in the upstream dts.
+	 * Remove these once fixed upstream.
+	 */
+	gpio-keys {
+		power {
+			gpios = <&gpio1 8 GPIO_ACTIVE_LOW>;
+		};
+
+		volume-up {
+			gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
+		};
+
+		volume-down {
+			gpios = <&gpio2 15 GPIO_ACTIVE_LOW>;
+		};
+	};
 };
 
 &esdhc1 {
-- 
2.7.0




More information about the barebox mailing list