[PATCH v4] Terasic DE0-Nano-SoC: add support

[Andrey Smirnov]

On Tue, Feb 2, 2016 at 3:30 PM, Trent Piepho <tpiepho at kymetacorp.com> wrote:
> On Mon, 2016-02-01 at 11:08 -0800, Andrey Smirnov wrote:
>> On Mon, Feb 1, 2016 at 8:09 AM, Tim Sander <tim at krieglstein.org> wrote:
>
>> > +
>> > +       if (IS_ENABLED(CONFIG_PHYLIB))
>> > +               phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK, phy_fixup);
>>
>> I don't think this code is correct. To the best of my knowledge, both
>> Atlas and DE0-Nano version of the board come with KSZ9031 as a PHY,
>> which requires different fixup. See arm/boards/tqma6x/board.c for
>> example.
>
> I think all the fixups for the micrel phys should probably be replaced
> with device tree properties.  If you look in drivers/net/phy/micrel.c,
> ksz9031_config_init() will read skew properties from the DT and program
> the phy that way.  This would make it easier to use the phy DT
> properties already in the Linux dts files.
>

I haven't thought about that, that does sound like a better idea.