[PATCH] mtd: nand_mxs: fix NAND error when change clk rate

Fabio Estevam festevam at gmail.com
Tue Dec 27 09:07:41 PST 2016


Hi Christian,

On Wed, Dec 21, 2016 at 7:38 PM, Christian Hemp <c.hemp at phytec.de> wrote:
> The function "nand_enable_edo_mode" changed the NAND clk rate, without turning
> it off. In this case it is posible to get the following errors:
>     MXS NAND: Error sending command
>     MXS NAND: Error sending command
>     MXS NAND: DMA read error
>
> This can be fixed if the NAND clk is disabled before we change the clk
> rate.
>
> Tested with:
> nand: NAND device: Manufacturer ID: 0x2c, Chip ID: 0xdc (Micron
> MT29F4G08ABADAWP), 512MiB, page size: 2048, OOB size: 64
>
> Signed-off-by: Christian Hemp <c.hemp at phytec.de>
> ---
>  drivers/mtd/nand/nand_mxs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/nand_mxs.c b/drivers/mtd/nand/nand_mxs.c
> index cba0bee..ce79bca 100644
> --- a/drivers/mtd/nand/nand_mxs.c
> +++ b/drivers/mtd/nand/nand_mxs.c
> @@ -2047,7 +2047,9 @@ static int mxs_nand_enable_edo_mode(struct mxs_nand_info *info)
>         nand->select_chip(mtd, -1);
>
>         /* [3] set the main IO clock, 100MHz for mode 5, 80MHz for mode 4. */
> +       clk_disable(info->clk);
>         clk_set_rate(info->clk, (mode == 5) ? 100000000 : 80000000);
> +       clk_enable(info->clk);

Yes, this is needed to fix erratum ERR007117.
(http://cache.nxp.com/assets/documents/data/en/errata/IMX6DQCE.pdf)

I will prepare the same fix for the kernel, thanks.



More information about the barebox mailing list