[PATCH] ata: intf_platform_ide: add OF bindings
s.hauer at pengutronix.de
Thu Sep 3 11:16:36 PDT 2015
On Thu, Sep 03, 2015 at 07:31:55PM +0300, Antony Pavlov wrote:
> On Thu, 03 Sep 2015 17:46:32 +0200
> Lucas Stach <l.stach at pengutronix.de> wrote:
> > Hi Peter.
> > Sorry, but this patch is wrong. You can't just make up completely ad-hoc
> > DT bindings. You are pushing platformdata 1:1 into the DT, which is not
> > how the conversion to DT should be done.
> > There is also no pre-existing binding for "ata-generic" in the Linux
> > kernel which would define any of those properties.
> Hmmm. in linux-4.2/drivers/ata/pata_of_platform.c I see "ata-generic"
> with "reg-shift" and "pio-mode" properties.
It seems this binding comes from the good old days when writing binding
doc was an optional task ;)
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox