[PATCH 2/3] scripts/kwbimage: Make BINARY files relative to config file

[Sascha Hauer]

On Thu, Oct 15, 2015 at 11:00:37AM +0200, Thomas Petazzoni wrote:
> Sascha,
> 
> On Thu, 15 Oct 2015 10:18:55 +0200, Sascha Hauer wrote:
> > The BINARY files given in the config files are expected to be relative
> > to the place kwbimage is called from. This is bad since it breaks where
> > kwbimage is called from the build directory and not the source
> > directory.
> > It makes more sense to make the paths in the config files relative
> > to the config files which works with out of tree builds and is also
> > more what a user normally expects.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> 
> In practice those binary.0 files are not really part of the Barebox
> source code. The binary.0 file has to be extracted from a vendor U-Boot
> binary prior to doing the Barebox build, so it isn't exactly part of
> the "source tree".

Yes, right.

> 
> Though I agree it is probably easier to extract them once and keep them
> around in the source tree (not checked-in, of course).

I think this aswell. The build tree often is deleted, but then the
binary.0 images should still be available.

> 
> Note that U-Boot now has a fully open-source implementation of this
> binary.0 thing, at least for Armada XP and Armada 38x. However, it's
> basically copy/pasted from the vendor U-Boot, so it's not very pretty
> to look at:
> 
>  - http://git.denx.de/?p=u-boot.git;a=tree;f=drivers/ddr/marvell
>    for the DDR initialization code.

Nice to have, indeed not nice to look at. This code is huge...

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |