[PATCH] graphics_utils: check for valid framebuffer before creating a screen

Sascha Hauer s.hauer at pengutronix.de
Thu Nov 12 23:37:37 PST 2015


Otherwise we crash later when we try to print on that screen.

Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
 lib/gui/graphic_utils.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/gui/graphic_utils.c b/lib/gui/graphic_utils.c
index 4c1885d..2fe9fa3 100644
--- a/lib/gui/graphic_utils.c
+++ b/lib/gui/graphic_utils.c
@@ -249,6 +249,10 @@ struct screen *fb_create_screen(struct fb_info *info)
 {
 	struct screen *sc;
 
+	if (!info->xres || !info->yres || !info->line_length ||
+			!info->screen_base)
+		return ERR_PTR(-EINVAL);
+
 	sc = xzalloc(sizeof(*sc));
 
 	sc->s.x = 0;
-- 
2.6.1




More information about the barebox mailing list