[PATCH] usb: increase USB_CNTL_TIMEOUT to match linux

Sascha Hauer s.hauer at pengutronix.de
Mon May 4 00:23:26 PDT 2015


On Tue, Apr 28, 2015 at 12:51:49PM +0200, Steffen Trumtrar wrote:
> USB requests should be processed within a timeframe of 5s.
> The linux kernel also uses this timeout value for the control packets.
> 
> For the musb the increase in timeout helps successfully probing USB devices
> (at least on one test hardware), but on the other hand doesn't slow down the
> system, if there are no devices, i.e. the timeout never hits. That means,
> that the USB core correctly aborts instead of timing out.
> Why and how the 100ms was chosen in the first place, can not be deduced from
> the git history, just that it seems to work fine for most boards.
> 
> Change USB_CNTL_TIMEOUT to 5000ms and replace all occurences of
> 	`USB_CNTL_TIMEOUT * x`
> with just
> 	`USB_CNTL_TIMEOUT`,
> as the timeout is now large enough without it.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar at pengutronix.de>
> ---
>  drivers/usb/core/usb.c | 4 ++--
>  include/usb/usb.h      | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list