saveenv & erase with bad blocks present

[Boulais, Marc-Andre]

Hi Sascha,
I start the patched/fixed version in second stage. My PCM049 board is programmed with Phytec's BSP Barebox 2013.06.0. Upon entering its prompt, I start v 15.02.0 with your patches using tftp and bootm commands.

The "wrong crc on env superblock" message appears after I execute v15.02.0 with the bootm comand. It does not appear in the resident Barebox startup.

Note: The first time I tried your patches, I had this error message:
nand_erase_nand: attempt to erase a bad block at page [...]

Since we were considering potential problems in the nand driver to cause a "false" bad block, I commented out the bad block check in function nand_erase_nand() (nand/nand_base.c):
 	instr->state = MTD_ERASING;

	while (len) {
#if 0
		/* Check if we have a bad block, we do not erase bad blocks! */
		if (!mtd->allow_erasebad &&
				nand_block_checkbad(mtd, ((loff_t) page) <<
					chip->page_shift, 0, allowbbt)) {
			pr_warn("%s: attempt to erase a bad block at page 0x%08x\n",
				    __func__, page);
			instr->state = MTD_ERASE_FAILED;
			goto erase_exit;
		}
#endif
	....

And then the erase operation appeared to have succeeded. After doing a reset and reloading Barebox v15.02.0, if I modify the environment and then execute "saveenv", my changes do not appear to ve saved if I do another reset...I am starting to think there was indeed a bad block in the bareboxenv NAND partition...I am checking with Phytec now.

Marc-Andre


-----Original Message-----
From: Sascha Hauer [mailto:s.hauer at pengutronix.de] 
Sent: February-09-15 2:19 AM
To: Boulais, Marc-Andre
Cc: barebox at lists.infradead.org
Subject: Re: saveenv & erase with bad blocks present

On Fri, Feb 06, 2015 at 05:03:59PM +0000, Boulais, Marc-Andre wrote:
> Ok, I did erase the nand0.bareboxenv partition and after a reset, partition size for the env looks good: 
> barebox at Phytec phyCORE-OMAP4460:/ ls /dev/nand0.bareboxenv* -l
> crw-------     131072 /dev/nand0.bareboxenv.bb   
> crw-------     131072 /dev/nand0.bareboxenv 
> barebox at Phytec phyCORE-OMAP4460:/ loadenv -d -s loading environment 
> from defaultenv barebox at Phytec phyCORE-OMAP4460:/ saveenv saving 
> environment
> 
> So I can now save the environment without errors. But if I edit the config file and then do "saveenv" and then I reset, my changes are not there anymore as if the saveenv didn't work.
> 
> Furthermore, I have this message " wrong crc on env superblock" that appears  in the boot output...
> What do you think ?

I'll try to reproduce that tomorrow.

Just to be sure: You applied the patches I posted to the list in the meantime. Is the barebox version flashed on your board the version with the patches applied or did you only start the fixed version second stage?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |