[RFC] usb: ehci-hcd: add OF bindings

[Sascha Hauer]

On Thu, Aug 27, 2015 at 07:48:31PM +0300, Peter Mamonov wrote:
> Signed-off-by: Peter Mamonov <pmamonov at gmail.com>
> ---
>  drivers/usb/host/ehci-hcd.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 1146b71..ef555eb 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -940,12 +940,16 @@ static int ehci_probe(struct device_d *dev)
>  {
>  	struct ehci_data data = {};
>  	struct ehci_platform_data *pdata = dev->platform_data;
> +	struct device_node *dn = dev->device_node;
> +	uint32_t flags;
>  
>  	/* default to EHCI_HAS_TT to not change behaviour of boards
>  	 * without platform_data
>  	 */
>  	if (pdata)
>  		data.flags = pdata->flags;
> +	else if (dn && of_property_read_u32(dn, "flags", &flags) == 0)
> +		data.flags = flags;

Shouldn't you check the has-transaction-translator boolean property
instead? That's what documented in dts/Bindings/usb/usb-ehci.txt

Otherwise looks good.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |