[PATCH 1/2] EFI: fix error handling in efi_get_boot()

Sascha Hauer s.hauer at pengutronix.de
Mon Sep 1 02:03:40 PDT 2014


On Tue, Aug 12, 2014 at 11:37:20AM +0200, Michael Olbrich wrote:
> efi_get_global_var() returns an error code, not NULL when it fails.
> 
> Signed-off-by: Michael Olbrich <m.olbrich at pengutronix.de>

Applied this one, thanks

Sascha

> ---
>  arch/efi/efi/efi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/efi/efi/efi.c b/arch/efi/efi/efi.c
> index ff97783..7de8ec8 100644
> --- a/arch/efi/efi/efi.c
> +++ b/arch/efi/efi/efi.c
> @@ -104,7 +104,7 @@ struct efi_boot *efi_get_boot(int num)
>  
>  	free(name);
>  
> -	if (!buf) {
> +	if (IS_ERR(buf)) {
>  		free(boot);
>  		return NULL;
>  	}
> -- 
> 2.0.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list