[PATCH] serial: imx: Fix buggy transmissions when baudrate mismatches

Sascha Hauer s.hauer at pengutronix.de
Mon Jun 2 00:22:36 PDT 2014


On Wed, May 28, 2014 at 04:57:18PM -0300, Fabio Estevam wrote:
> On Thu, May 15, 2014 at 7:05 PM, Fabio Estevam <festevam at gmail.com> wrote:
> > Hi Sascha,
> >
> > On Thu, May 15, 2014 at 6:21 PM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> >
> >>> --- a/drivers/serial/serial_imx.c
> >>> +++ b/drivers/serial/serial_imx.c
> >>> @@ -258,7 +258,8 @@ static int imx_serial_getc(struct console_device *cdev)
> >>>         while (readl(priv->regs + priv->devtype->uts) & UTS_RXEMPTY);
> >>>
> >>>         ch = readl(priv->regs + URXD0);
> >>> -
> >>> +       if (ch >= 0x80)
> >>> +               ch = '?';
> >>
> >> This is not part of the fix, right?
> >
> > Correct, this is not part of the fix.
> >
> > This code is just to help reproducing the issue in console, without
> > the need of hooking an oscilloscope to the UART pins or inspecting
> > directly the UART TX registers.
> 
> Any comments, Sascha?

No, I assumed you resend the patch without the hunk above.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list