[PATCH 2/3] ARM: dts: i.MX53: tqma53: Add barebox specifics

Sascha Hauer s.hauer at pengutronix.de
Wed Jan 22 01:33:14 EST 2014


On Tue, Jan 21, 2014 at 09:17:55AM +0100, Sascha Hauer wrote:
> On Mon, Jan 20, 2014 at 07:25:50PM +0100, Alexander Aring wrote:
> > Hi Sascha,
> > 
> > On Mon, Jan 20, 2014 at 02:23:55PM +0100, Sascha Hauer wrote:
> > > - add chosen node with
> > >   - environment
> > >   - linux,stdout-path
> > > - add dsr value to eMMC
> > > - add provide-mac-address property to iim node
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > > ---
> > >  arch/arm/dts/imx53-mba53.dts   | 17 +++++++++++++++++
> > >  arch/arm/dts/imx53-tqma53.dtsi | 15 ++++++++++++++-
> > >  2 files changed, 31 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/dts/imx53-mba53.dts b/arch/arm/dts/imx53-mba53.dts
> > > index a630902..43bb12c 100644
> > ...
> > > +
> > >  	memory {
> > > -		reg = <0x70000000 0x40000000>; /* Up to 1GiB */
> > > +		reg = <0x70000000 0x0>; /* Up to 1GiB */
> > 
> > Is this change correct? You don't mention it in commit-msg and it confusing
> > me a little bit to set this zero. :-)
> 
> The change is necessary. The tqma53 comes with 512MiB or 1GiB. During
> barebox startup the SDRAM first gets registered by the devicetree
> information, but this is wrong for the 512MiB boards. The correct
> SDRAM size is derived from the SDRAM controller settings later from
> arch/arm/mach-imx/esdctl.c. This only works as long as the devicetree
> parser hasn't registered conflicting SDRAM earlier.

I added a comment to the commit log before applying it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list