[SPAM] [PATCH] common: fix possible build problem without password support

[Jan Lübbe]

Hi,

On Mon, 2013-10-14 at 17:46 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >  quiet_cmd_pwd_h = PWDH    $@
> > +ifdef CONFIG_PASSWORD
> 
> ??
> 
> so if no password then it do
> 
> cmd_pwd_h = echo "const char default_passwd[] = \"\";" > $@
> 
> that's all
> 
> so we do not need to check CONFIG_PASSSORD

No. Try adding 'set -x;' to the shell call and building without
CONFIG_PASSWORD. In that case CONFIG_PASSWORD_DEFAULT is not set.
An unset Kconfig variable is not equal to "".

> >  ifneq ($(CONFIG_PASSWORD_DEFAULT),"")
> >  PASSWD_FILE := $(shell cd $(srctree); find $(CONFIG_PASSWORD_DEFAULT) -type f)

Try with:
PASSWD_FILE := $(shell set -x; cd $(srctree); echo `find $(CONFIG_PASSWORD_DEFAULT) -type f`)

> >  cmd_pwd_h = echo -n "const char default_passwd[] = \"" > $@; \
> > @@ -134,6 +135,7 @@ endif
> >  targets += include/generated/passwd.h
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |