[PATCH 1/2] OMAP4: fix writel data/address swap regression

Alexander Aring alex.aring at gmail.com
Mon Nov 25 02:34:54 EST 2013


On Mon, Nov 25, 2013 at 08:31:44AM +0100, Sascha Hauer wrote:
> On Sat, Nov 23, 2013 at 08:58:23PM +0100, Vicente Bergas wrote:
> > ---
> >  arch/arm/mach-omap/omap4_clock.c | 176 +++++++++++++++++++--------------------
> >  1 file changed, 88 insertions(+), 88 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap/omap4_clock.c b/arch/arm/mach-omap/omap4_clock.c
> > index 268f7c1..72f72a1 100644
> > --- a/arch/arm/mach-omap/omap4_clock.c
> > +++ b/arch/arm/mach-omap/omap4_clock.c
> > @@ -89,7 +89,7 @@ void omap4_configure_per_dpll(const struct dpll_param *dpll_param)
> >  void omap4_configure_abe_dpll(const struct dpll_param *dpll_param)
> >  {
> >  	/* Select sys_clk as ref clk for ABE dpll */
> > -	writel(CM_ABE_PLL_REF_CLKSEL, 0x0);
> > +	writel(0x0, CM_ABE_PLL_REF_CLKSEL);
> 
> What a silly bug! Who messed this up? Damn. me :(. Applied both, thanks
> 
Yea, I will put this on my list what I should ever check on patches with
writel. :-)

- Alex



More information about the barebox mailing list