Re: [PATCH 2/3] ARM: i.mx53: Parse Reset GPIO pin in FEC driver from Devicetree

[Alexander Shiyan]

> On Wed, Nov 20, 2013 at 10:22:25PM +0100, Rostislav Lisovy wrote:
> > Signed-off-by: Rostislav Lisovy <lisovy at gmail.com>
> > 
> > diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
...
> > +	phy_reset = of_get_named_gpio(dev->device_node, "phy-reset-gpios", 0);
> > +	if (!gpio_is_valid(phy_reset)) {
> > +		dev_info(dev, "'phy-reset' gpio is not valid\n");
> 
> Applied this series, but dropped this message. The problem with these
> kind of messages is that now nearly all i.MX users start seeing it and
> wonder if this is something they have to care about.

"phy-reset-duration" property should be handled together with "phy-reset-gpios"-property.
Additionally, the reset level is hardcoded to "0", but should be taken from
2nd cell GPIO DT definition.
I am not sure about 2nd issue, but the first can be implemented very easy.

---