[PATCH] read_file: Make it work on tftp servers which do not pass size

Sascha Hauer s.hauer at pengutronix.de
Fri Jun 21 04:21:30 EDT 2013


On Fri, Jun 21, 2013 at 09:46:41AM +0200, Jan Weitzel wrote:
> Am Freitag, den 21.06.2013, 09:10 +0200 schrieb Sascha Hauer:
> > On Fri, Jun 21, 2013 at 09:03:31AM +0200, Jan Weitzel wrote:
> > > Am Donnerstag, den 20.06.2013, 17:24 +0200 schrieb Sascha Hauer:
> > > > 
> > > > How do you want to do that? You would have to transfer the whole file
> > > > first and see how big it is. That works for small files we expect to fit
> > > > into memory like the ones read_file normally is called with. If you want
> > > > to transfer a rootfs image it might happen that it's bigger than the
> > > > available memory.
> > > That's a good point. I didn't see a way for big files. But setting the
> > > st_size to FILESIZE_MAX can cause trouble in other commands. ubiformat
> > > only blames that is doesn't fit to eraseblock boundaries.
> > 
> > Have you tried it?
> Yes, with a v2013.03.0 based barebox. Without the patch ubiformat -f
> erase the ubi volume and "writes" a image of size 0.

I assume it does so even when the image is not of size 0, right?
That sounds broken.

Aynway, you are beginning to convince me that 0 might be a better
choice.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list