[PATCH] devfs-core: introduce devfs_append_partition
jlu at pengutronix.de
Wed Jun 19 02:32:48 EDT 2013
On Wed, 2013-06-19 at 10:03 +0400, Alexander Shiyan wrote:
> > On Tue, Jun 18, 2013 at 02:50:50PM +0200, Jan Luebbe wrote:
> > > This simplifies board code for partition setup by keeping track of the
> > > offset.
> > >
> > > Signed-off-by: Jan Luebbe <jlu at pengutronix.de>
> > Good idea. There seem to be some bugs in this area. I'm fine with the
> > patch when some users are converted to this.
> But lets make static variable "offset", setup it in devfs_add_partition and
> just add "size" in the devfs_append_partition.
> Otherwise I do not see any difference between "add" and "append".
I'd prefer to have the state where it's obvious to the caller and not in
a static variable somewhere else. :)
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox