Re: [PATCH] Remove a redundant line.

Alexander Shiyan shc_work at mail.ru
Sun Jun 2 09:13:18 EDT 2013


> Signed-off-by: Masaki Muranaka <monaka at monami-ya.com>
> ---
>  commands/echo.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/commands/echo.c b/commands/echo.c
> index 8929234..4dfd870 100644
> --- a/commands/echo.c
> +++ b/commands/echo.c
> @@ -55,7 +55,6 @@ static int do_echo(int argc, char *argv[])
>  			break;
>  		case 'o':
>  			oflags |= O_TRUNC;
> -			file = argv[optind + 1];
>  			if (optind + 1 < argc)
>  				file = argv[optind + 1];
>  			else
> -- 

Nice catch. This is a possible crash.

---


More information about the barebox mailing list