[RFC 0/2] mci: Dove SDHCI driver

[Sascha Hauer]

On Fri, Jul 05, 2013 at 11:22:17PM +0200, Sebastian Hesselbarth wrote:
> This RFC presents a working SDHCI driver for the IP found on Marvell
> Dove SoCs.
> 
> @Sascha: We talked about refactoring common SDHCI code and I just want
> to show what I came up with for Dove. After thinking about existing barebox
> SDHCI, I had the impression that I should reimplement Dove SDHCI with writel
> as it is already made in other SDHCI drivers.

Yes, common register accessors would make it possible to share code.
Maybe we can start with some sdhc_write[bwl]/read[bwl] functions which
are static inline wrappers around regular writel/readl. This would make
it possible to add an indirection there should we have to.

> 
> I will be not checking mails regularily nor working on Barebox for the next
> two weeks, so feel free to simply ignore the RFC. But I thought it will be
> a good way to discuss your plans for common SDHCI code.

I think the driver looks mostly good. It should be a good base to factor
out common code in the future.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |