[PATCH v2 06/10] spi: add Marvell MVEBU SoC SPI driver

[Sascha Hauer]

On Tue, Jul 02, 2013 at 08:30:45PM +0200, Sebastian Hesselbarth wrote:
> This adds support for the SPI controller found on Marvell MVEBU SoCs
> (Dove, Kirkwood, Discovery Innovation, and Armada 370/XP). Current driver
> is DT only. Compatible strings are provided for Orion (common denominator),
> Armada 370/XP and Dove SoCs.
> 
> +#if defined(ARCH_ARMADA_370) || defined(ARCH_ARMADA_XP)

These have to be CONFIG_*. Also elsewhere in this patch.

> +static int mvebu_spi_probe(struct device_d *dev)
> +{
> +	struct spi_master *master;
> +	struct mvebu_spi *priv;
> +	const struct of_device_id *match;
> +	int ret = 0;
> +
> +	match = of_match_node(mvebu_spi_dt_ids, dev->device_node);
> +	if (!match)
> +		return -EINVAL;
> +
> +	priv = xzalloc(sizeof(*priv));
> +	priv->base = dev_request_mem_region(dev, 0);
> +	if (!priv->base) {
> +		ret = -EINVAL;
> +		goto err_free;
> +	}
> +	priv->set_baudrate = (void *)match->data;
> +	priv->clk = clk_lookup("tclk");

still clk_lookup?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |