[PATCH 8/8] memtest: add rewritten memtest command

[Sascha Hauer]

Hi Alexander,

On Wed, Jan 23, 2013 at 09:01:36PM +0100, Alexander Aring wrote:
> > > +/*
> > > + * PTE flags variables to set cached and
> > > + * uncached regions.
> > > + */
> > > +static uint32_t PTE_FLAGS_CACHED;
> > > +static uint32_t PTE_FLAGS_UNCACHED;
> > 
> > Please no uppercase letters for variable names.
> >
> Ok. I took it from mach/arm/cpu/mmu.c, should I create a patch which
> rename it in arch/arm/cpu/mmu.c lower case, too?

Yes, that would be great. I must have forgotten reviewing my own patch
;)

> 
> > > +#else
> > > +static char optstr[] = "s:e:i:b";
> > > +#endif
> > > +
> > > +/*
> > > + * Perform a memory test. The complete test
> > > + * loops until interrupted by ctrl-c.
> > > + */
> > > +static int mem_test(vu_long _start, vu_long _end,
> > > +		int bus_only)
> > 
> > It would be good to move this function to common/memory_test.c. This way
> > it could be called from C. Especially testing memory might be called
> > from some early small (no shell) development binaries which are running from some
> > internal SRAM.
> > 
> Ok.
> Maybe we can do a menu entry via Kconfig or something else to run a
> memtest after booting automatically.

Maybe this could be added as an init script in the environment, but
personally I don't think I'll run it by default on our boards. We are
more into booting fast.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |