[PATCH 1/1] Makefile: drop duplicate cmd_as_o_S support

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Tue Feb 26 07:49:47 EST 2013


On 11:09 Tue 26 Feb     , Sascha Hauer wrote:
> On Wed, Feb 20, 2013 at 03:25:15PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > as we have it to in scripts/Makefile.lib
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > ---
> >  Makefile |    8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index a27c07a..7f97e8f 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1210,14 +1210,6 @@ quiet_cmd_rmdirs = $(if $(wildcard $(rm-dirs)),CLEAN   $(wildcard $(rm-dirs)))
> >  quiet_cmd_rmfiles = $(if $(wildcard $(rm-files)),CLEAN   $(wildcard $(rm-files)))
> >        cmd_rmfiles = rm -f $(rm-files)
> >  
> > -
> > -a_flags = -Wp,-MD,$(depfile) $(AFLAGS) $(AFLAGS_KERNEL) \
> > -	  $(NOSTDINC_FLAGS) $(CPPFLAGS) \
> > -	  $(modkern_aflags) $(EXTRA_AFLAGS) $(AFLAGS_$(basetarget).o)
> > -
> > -quiet_cmd_as_o_S = AS      $@
> > -cmd_as_o_S       = $(CC) $(a_flags) -c -o $@ $<
> > -
> >  # read all saved command lines
> 
> I dropped this one as it breaks compilation in a number of defconfigs:
> 
> cupid_defconfig:
> /bin/sh: 1: Syntax error: ";" unexpected
> make: *** [.tmp_kallsyms1.o] Error 2

I found the as_o_S is in Makefile.build not .lib

so not alwaysed included do not known why
this should be

> 
> I haven't investigated the reasons.

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list