[For master PATCH 1/1] grapric_utils: set_pixel only write 16bit in 16bit mode

Sascha Hauer s.hauer at pengutronix.de
Thu Feb 21 09:08:55 EST 2013


On Thu, Feb 21, 2013 at 03:01:42PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:56 Thu 21 Feb     , Sascha Hauer wrote:
> > On Tue, Feb 19, 2013 at 10:24:14AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > > ---
> > >  lib/gui/graphic_utils.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/lib/gui/graphic_utils.c b/lib/gui/graphic_utils.c
> > > index 95687df..a1be5d0 100644
> > > --- a/lib/gui/graphic_utils.c
> > > +++ b/lib/gui/graphic_utils.c
> > > @@ -104,7 +104,7 @@ void set_pixel(struct fb_info *info, void *adr, u32 px)
> > >  	case 8:
> > >  		break;
> > >  	case 16:
> > > -		*(u16 *)adr = px;
> > > +		*(u16 *)adr = px & 0xffff;
> > 
> > What does this fix? The result should be the same.
> not on qemu

Isn't this a bug in qemu?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list