Re[2]: [RFC] Add Generic GPIO driver

Alexander Shiyan shc_work at mail.ru
Tue Feb 19 02:34:49 EST 2013


...
> > > > > > This patch adds generic memory-mapped GPIO controller support.
> > > > > > Code taken from Linux Kernel and adopted for barebox.
> > > > > 
> > > > > I'm fine with this if you add a user for it. I wonder though if it's
> > > > > worth it to have this driver for barebox. If I have a driver in the
> > > > > kernel that already uses it, then this makes it simple to copy it, but
> > > > > should I have to write a new gpio driver, I'm unsure if it's simpler
> > > > > to write a new gpio driver or to register with the generic gpio
> > > > > driver.
> > > > 
> > > > Here's an example that I'm checking:
> > > 
> > > Ok, this indeed looks nice and short. You convinced me ;)
> > > 
> > > As said, I'm fine with the generic gpio driver if you add the below as
> > > first user.
> > 
> > I still beg to consider patch for generic GPIO separately.
> > Then I will send you two completely different versions of the implementation
> > GPIO for CLPS711X for consideration.
> 
> I don't know if I'm misunderstanding you. Of course the generic GPIO
> driver and the CLPS711x driver should be two separate patches, but
> both should come in the same series. I just want to wait applying the
> generic driver until we have a user (and thus compile coverage).

No, no, no. I say that I have two different implementations of gpio-clps711x,
both is based on generic-gpio but I cannot choose between these :)

---


More information about the barebox mailing list