Re[2]: [PATCH v2 3/9] ARM: clps711x: Adds config option for CPU PLL multiplier

Alexander Shiyan shc_work at mail.ru
Wed Feb 13 12:20:09 EST 2013


> > Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> > ---
> >  arch/arm/boards/clep7212/lowlevel.c            |    6 +++++-
> >  arch/arm/mach-clps711x/Kconfig                 |   13 +++++++++++++
> >  arch/arm/mach-clps711x/include/mach/clps711x.h |    2 +-
> >  arch/arm/mach-clps711x/lowlevel.c              |    7 +++++--
> >  4 files changed, 24 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/boards/clep7212/lowlevel.c b/arch/arm/boards/clep7212/lowlevel.c
> > index b7d6d1d..fcf8285 100644
> > --- a/arch/arm/boards/clep7212/lowlevel.c
> > +++ b/arch/arm/boards/clep7212/lowlevel.c
> > @@ -14,9 +14,13 @@
> >  
> >  #include <mach/clps711x.h>
> >  
> > +#if (CONFIG_CLPS711X_CPU_PLL_MULT < 20) || (CONFIG_CLPS711X_CPU_PLL_MULT > 50)
> > +# error "CPU PLL multiplier out of range"
> > +#endif
> > +
> >  void __naked __bare_init barebox_arm_reset_vector(void)
> >  {
> >  	arm_cpu_lowlevel_init();
> >  
> > -	clps711x_barebox_entry();
> > +	clps711x_barebox_entry(CONFIG_CLPS711X_CPU_PLL_MULT);
> 
> I don't quite understand why you want to have this configurable. I mean
> this is a single board only, why not simply run it with the maximum
> allowed frequency? Or does this board come with multiple SoCs for which
> different maximum values exist?

Yes. There are 2 versions of the chip. One with a maximum operating
frequency of 74 MHz, second with 90 MHz. The only difference is on the CPU label.
Which version is used, it is impossible to know in runtime.
You can simply reject this patch [3/9], all other should not depend on this one.
Later I'll try to make another different version.

---


More information about the barebox mailing list