[Makefile bug] make barebox.s : dead loop

Sascha Hauer s.hauer at pengutronix.de
Mon Dec 2 04:13:20 EST 2013


On Mon, Dec 02, 2013 at 04:36:50PM +0800, Kevin Du Huanpeng wrote:
> I add barebox.s after the target barebox.S,
> It works.
> maybe should add the same thing with
> 
> ----------
> ifdef CONFIG_X86
> barebox.S: barebox
> ifdef CONFIG_X86_HDBOOT
> ------------
> 
> 
> @@ -723,7 +724,7 @@ endif
>         @echo " * Init Calls content" >> barebox.S
>         $(Q)$(OBJDUMP) -j .barebox_initcalls -d barebox >> barebox.S
>  else
> -barebox.S: barebox FORCE
> +barebox.S barebox.s: barebox FORCE
>         $(call if_changed,disasm)

Normally you are supposed to call 'make barebox.S' (with uppercase 'S'),
but I think it's fine to just add the same target with a lowercase 's'
like you did to make both work. Care to send a proper patch with
Signed-off-by?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list