Re: [PATCH 3/5] GPIO: i.MX: Rewrite driver for using generic GPIO code
shc_work at mail.ru
Mon Apr 22 05:23:24 EDT 2013
> > > On Sat, Apr 20, 2013 at 08:18:50AM +0400, Alexander Shiyan wrote:
> > > >
> > > > Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> > > > ---
> > > > arch/arm/Kconfig | 1 -
> > > > drivers/gpio/Kconfig | 1 +
> > > > drivers/gpio/gpio-imx.c | 125 ++++++++++++------------------------------------
> > > > 3 files changed, 31 insertions(+), 96 deletions(-)
> > > > config GPIO_IMX
> > > > def_bool ARCH_IMX
> > > > + select GPIO_GENERIC
> > >
> > > I'm not convinced by this change. Indeed this makes for smaller
> > > sourcecode, but the binary gets over 1kb bigger. I think this is too
> > > much for no additional gain.
> > The main idea of this change is reuse code if we can have multiple
> > targets in barebox. Probably, now is too early for this.
> Yeah, it may change once multiple gpio drivers are compiled into the
> BTW maybe you can lower the impact of the generic gpio driver by making
> the basic-mmio-gpio platform driver optional. It is not used by the i.MX
"basic-mmio-gpio" driver is a part of generic GPIO but it is already
a separate config symbol GPIO_GENERIC_PLATFORM.
In any case I will think about optimization this code.
More information about the barebox