[PATCH 2/3] dma: apbh: check for errors when resetting ip core

[Juergen Beisert]

Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>
> ---
>  drivers/dma/apbh_dma.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/apbh_dma.c b/drivers/dma/apbh_dma.c
> index 363878f..d30b8fb 100644
> --- a/drivers/dma/apbh_dma.c
> +++ b/drivers/dma/apbh_dma.c
> @@ -555,7 +555,9 @@ int mxs_dma_init(void)
>  	int ret, channel;
>  	u32 val, reg;
>
> -	mxs_reset_block(apbh_regs, 0);
> +	ret = mxs_reset_block(apbh_regs, 0);
> +	if (ret)
> +		return ret;

In this case the user faces a "MXS: Timeout resetting block via register ...". 
Do you think this message is helpful to give the user a pointer *where* the 
failure happens?

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |