[RFC PATCH] commands: change Y-Modem implementation

Sascha Hauer s.hauer at pengutronix.de
Sat Oct 27 08:21:18 EDT 2012


Hi Robert,

On Fri, Oct 26, 2012 at 09:00:11PM +0200, Robert Jarzmik wrote:
> The current Y-Modem implementation has some limitations:
>  - Y-Modem/G protocol is not supported
>  - Multiple files (aka. batch) transfers are not supported
>  - Transfer speed over fast lines (USB console) is slow
>  - Code is not trivial to maintain (personnal opinion)

This is my personal opinion aswell.

>From a first sight your code looks much better. When the problems are
solved we should go and replace the old code.

If you continue on this it would be nice to separate the protocol
implemention from the command so that it can be used from C code aswell
rather than only from the command.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list