[RFC 2/3] MIPS: add the initial support for lowlevel init

Antony Pavlov antonynpavlov at gmail.com
Mon May 14 05:13:49 EDT 2012


On 14 May 2012 12:55, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> On Sun, May 13, 2012 at 09:24:43PM +0400, Antony Pavlov wrote:
>> This commit introduce the initial support for
>> machine specific lowlevel initialization
>> (e.g. RAM controller or cache memory).
>>
>> To return from mach_init_lowlevel() it uses
>> explicit mach_init_lowlevel_return label.
>> This saves ra register for using inside mach_init_lowlevel()
>>
>> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
>> ---
>>  arch/mips/boot/start.S |    8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/mips/boot/start.S b/arch/mips/boot/start.S
>> index 6bf5baa..6db104b 100644
>> --- a/arch/mips/boot/start.S
>> +++ b/arch/mips/boot/start.S
>> @@ -74,6 +74,14 @@ __start:
>>       and     k0, k1
>>       mtc0    k0, CP0_STATUS
>>
>> +#ifdef CONFIG_MACH_DO_LOWLEVEL_INIT
>> +     b       mach_init_lowlevel
>> +      nop
>       ^^^^
>
> Space after tab.

It not a bug, it is a feature! :))

The nop instruction is in a branch delay slot, so add a space before it.

-- 
Best regards,
  Antony Pavlov



More information about the barebox mailing list