[PATCH] drivers/spi/spi.c: when allocating a struct device_d specify id as -1

Sascha Hauer s.hauer at pengutronix.de
Mon May 14 05:05:31 EDT 2012


On Mon, May 14, 2012 at 10:38:39AM +0200, Jan Luebbe wrote:
> This causes allocation of a free id and avoids conflicts if multiple
> identical SPI devices are attached.
> 
> Signed-off-by: Jan Luebbe <jlu at pengutronix.de>
> ---
>  drivers/spi/spi.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index 7a8aed4..b63d02f 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -78,6 +78,7 @@ struct spi_device *spi_new_device(struct spi_master *master,
>  	proxy->bits_per_word = chip->bits_per_word ? chip->bits_per_word : 8;
>  	proxy->dev.platform_data = chip->platform_data;
>  	strcpy(proxy->dev.name, chip->name);
> +	proxy->dev.id = -1; /* allocate a free id for this chip */

Please use DEVICE_ID_DYNAMIC instead.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list