[PATCH] omap3 towards thumb2 support

[Premi, Sanjeev]

> -----Original Message-----
> From: Sascha Hauer [mailto:s.hauer at pengutronix.de] 
> Sent: Tuesday, January 17, 2012 6:41 PM
> To: Premi, Sanjeev
> Cc: barebox at lists.infradead.org
> Subject: Re: [PATCH] omap3 towards thumb2 support
> 
> On Tue, Jan 17, 2012 at 12:24:26PM +0000, Premi, Sanjeev wrote:
> > > -----Original Message-----
> > > From: Sascha Hauer [mailto:s.hauer at pengutronix.de] 
> > > Sent: Tuesday, January 17, 2012 5:43 PM
> > > To: Premi, Sanjeev
> > > Cc: barebox at lists.infradead.org
> > > Subject: Re: [PATCH] omap3 towards thumb2 support
> > > 
> > > On Tue, Jan 17, 2012 at 11:14:31AM +0000, Premi, Sanjeev wrote:
> > 
> > [snip]
> > 
> > > > > 
> > > > > I attached my binary MLO file. Could you check if it 
> > > works for you? I
> > > > > just checked this binary and it comes up with:
> > > > > 
> > > > > [sp] I will try tomorrow morning.
> > > > 
> > > > Sascha,
> > > >   Your MLO boots fine. But I couldn't make repeat 
> success on either
> > > >   beagle or the omap3evem on my side.
> > > > 
> > > >   Each time there is an exception on entry of 
> setup_auxcr() on both
> > > >   boards. See attached image.
> > > > 
> > > >   I noticed that the size of the generated MLO for beagle 
> > > were different
> > > >   for us - 35224(yours) vs. 35572(mine).
> > > > 
> > > >   I am building with CodeSourcery 2011.03-41.
> > > 
> > > Ok, got it. Please replace the setup_auxcr patch with the 
> > > following one
> > > (I also updated the work/omap3 branch). The problem was 
> the missing
> > > ENDPROC(setup_auxcr) directive which tells the assembler that
> > > setup_auxcr is a function. With this the function is 
> correctly called
> > > with 'blx' instead of 'bl'. 'blx' is needed because setup_auxcr is
> > > compiled in arm mode instead of thumb2 mode. Somehow my toolchain
> > > got that right without ENDPROC but the codesourcery 
> toolchain didn't.
> > > With this patch the binary also works with the 
> codesourcery toolchain.
> > > 
> > 
> > I replaced the contents of auxcr.S and I am able to boot fine on the
> > OMAP3EVM.
> > 
> > BTW, I noticed that this file has no license header. Is this okay?
> 
> Added one. Can I have your tested-by?

Tested-by: Sanjeev Premi <premi at ti.com>

> 
> Sascha
> 
> 
> -- 
> Pengutronix e.K.                           |                  
>            |
> Industrial Linux Solutions                 | 
> http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: 
> +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   
> +49-5121-206917-5555 |
>