[PATCH 1/2] add CONFIG_BAREBOX_MAX_SIZE to check if the size of barebox exceed the target size

Sascha Hauer s.hauer at pengutronix.de
Mon Jan 16 04:26:27 EST 2012


On Sun, Jan 15, 2012 at 10:38:15AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> this will allow to detected silent oversize result

There are different sizes to consider. What you check here for is the
maximum binary image size. Another interesting size is whether the
image + bss fits into SRAM (for example for the OMAP xloader configs).
To avoid confusion I suggest to name this one
CONFIG_BAREBOX_MAX_IMAGE_SIZE.

> 
> if 0x0 the size will not been checked

Why not make the default 0xffffffff, then you don't have to check for
max_size != 0

Sascha

> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  Makefile       |    8 ++++++++
>  common/Kconfig |    8 ++++++++
>  2 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index d8e685e..eeb5b5d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -659,6 +659,14 @@ OBJCOPYFLAGS_barebox.bin = -O binary
>  
>  barebox.bin: barebox FORCE
>  	$(call if_changed,objcopy)
> +	size=`stat -c%s $@`; \
> +	max_size=`printf "%d" $(CONFIG_BAREBOX_MAX_SIZE)`; \
> +	if [ $$max_size -lt $$size -a \
> +	     $$max_size -ne 0 ] ; \
> +	then \
> +		echo "$@ size $$size > of the maximum size $$max_size"; \
> +		exit 1 ; \
> +	fi
>  
>  ifdef CONFIG_X86
>  barebox.S: barebox
> diff --git a/common/Kconfig b/common/Kconfig
> index 382e591..a034686 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -104,6 +104,14 @@ config TEXT_BASE
>  	help
>  	  The Address barebox gets linked at.
>  
> +config BAREBOX_MAX_SIZE
> +	prompt "Maximum size of barebox"
> +	hex
> +	default 0x0
> +	help
> +	  Define the maximum size of barebox
> +	  If 0x0 the size will not been check
> +
>  config HAVE_CONFIGURABLE_MEMORY_LAYOUT
>  	bool
>  
> -- 
> 1.7.7
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list