[PATCH 1/2] Preparation stage to support multiple PPC architectures.

Sascha Hauer s.hauer at pengutronix.de
Mon Jan 2 06:30:36 EST 2012


On Thu, Dec 29, 2011 at 11:13:30AM +0000, Renaud Barbier wrote:
> diff --git a/arch/ppc/mach-mpc5xxx/Kconfig b/arch/ppc/mach-mpc5xxx/Kconfig
> index 632fb85..088d07e 100644
> --- a/arch/ppc/mach-mpc5xxx/Kconfig
> +++ b/arch/ppc/mach-mpc5xxx/Kconfig
> @@ -1,3 +1,55 @@
> +if ARCH_MPC5XXX
> +
> +config CLOCKSOURCE_MASK
> +	int
> +	default 32
> +
> +config CLOCKSOURCE_SHIFT
> +	int
> +	default 15

Please no kconfig variable for this. It's easier to just have some SoC
specific include file for this. But please let me first see your 8xxx
patches. arch/ppc/lib/time.c has some (currently unused) #ifdefs and it
might be more appropriate to create a time-8xxx.c (and moving time.c to
time-mpc5200.c) instead of ifdeffing a 75 line file.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list